Issue 36690: A typing error in demo rpython.py
Created on 2019-04-21 12:52 by jiawei zhou, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 12903 | merged | python-dev, 2019-04-22 07:10 | |
| PR 12906 | merged | miss-islington, 2019-04-22 13:29 | |
| Messages (5) | |||
|---|---|---|---|
| msg340606 - (view) | Author: jiawei zhou (jiawei zhou) * | Date: 2019-04-21 12:52 | |
Hi. There is an error in file `Tools/demo/rpython.py` at line 22. The original statement is `port = int(port[i+1:])`, but it will crash if the port is specified as parameters. The correct code should be `port = int(host[i+1:])`. Then the program can read specified port from parameter sys.argv[1]. |
|||
| msg340609 - (view) | Author: SilentGhost (SilentGhost) *  |
Date: 2019-04-21 14:13 | |
Would you be interested in submitting a PR on github? Guidelines can be found on https://devguide.python.org/pullrequest/ if you're not sure how to proceed. |
|||
| msg340651 - (view) | Author: Berker Peksag (berker.peksag) *  |
Date: 2019-04-22 13:29 | |
New changeset d59b662e490d3fae662c5f81fa5248f0445d2158 by Berker Peksag (周家未) in branch 'master': bpo-36690: Fix typo in Tools/demo/rpython.py (GH-12903) https://github.com/python/cpython/commit/d59b662e490d3fae662c5f81fa5248f0445d2158 |
|||
| msg340653 - (view) | Author: Berker Peksag (berker.peksag) * |
Date: 2019-04-22 13:54 | |
New changeset 5407aaf18b8d33d0a327991db366457ac6fead2d by Berker Peksag (Miss Islington (bot)) in branch '3.7': bpo-36690: Fix typo in Tools/demo/rpython.py (GH-12903) https://github.com/python/cpython/commit/5407aaf18b8d33d0a327991db366457ac6fead2d |
|||
| msg340654 - (view) | Author: Berker Peksag (berker.peksag) * |
Date: 2019-04-22 13:54 | |
Thank you! |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:14 | admin | set | github: 80871 |
| 2019-04-22 13:54:38 | berker.peksag | set | status: open -> closed resolution: fixed messages: + msg340654 stage: patch review -> resolved |
| 2019-04-22 13:54:00 | berker.peksag | set | messages: + msg340653 |
| 2019-04-22 13:29:18 | berker.peksag | set | nosy:
+ berker.peksag messages: + msg340651 |
| 2019-04-22 13:29:09 | miss-islington | set | pull_requests: + pull_request12833 |
| 2019-04-22 08:01:32 | SilentGhost | set | nosy:
+ gvanrossum |
| 2019-04-22 07:10:11 | python-dev | set | keywords:
+ patch stage: needs patch -> patch review pull_requests: + pull_request12831 |
| 2019-04-21 14:13:21 | SilentGhost | set | keywords: + easy |
| 2019-04-21 14:13:00 | SilentGhost | set | versions:
+ Python 3.7, Python 3.8 nosy: + SilentGhost messages: + msg340609 type: crash -> behavior |
| 2019-04-21 12:52:55 | jiawei zhou | create | |