With issue17185 __signature__ was set so that inspect can use this to return signature for mock objects. But in PySide2 it has __signature__ set as a non-writeable property and hence trying to set __signature__ fails. It's actually setting __signature__ for mocked object but still has this error for PySide.

mock backport report : https://github.com/testing-cabal/mock/issues/464
pytest-qt report : https://github.com/pytest-dev/pytest-qt/issues/258

As noted in https://github.com/testing-cabal/mock/issues/464#issuecomment-490381389 just importing PySide2 makes __signature__ not writeable for any class defined after the import.

$ python
Python 3.8.0a4+ (heads/master:b1c3167c23, May  8 2019, 05:17:38)
[GCC 5.4.0 20160609] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> class Foo: pass
...
>>> Foo.__signature__ = 1
>>> import PySide2
>>> class Bar: pass
...
>>> Bar.__signature__ = 1
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: attribute '__signature__' of 'type' objects is not writable

Wow, is this just an issue that the pyside guys need to fix?

> Wow, is this just an issue that the pyside guys need to fix?

I guess so. PySide __init__.py has "import shiboken" which also does type.__signature__. It seems like shiboken is some kind of generator to generate Python bindings from C++ QT code. I couldn't dig any deeper. Since this has caused two reports of regression I can add an except block to silence the AttributeError and add a comment to this issue but can only test it manually installing pyside to ensure the AttributeError is not thrown.

I'm not sure we should try and work around this; hijacking __signature__ python-wide is going to cause a bunch of other problems. My vote would be to just open a bug on the pyside tracker (wherever that is) and close the issue and and on the backport by pointing to that issue.

thoughts?

Agree, for the general case I think it makes sense that this is fixed in pyside.
Hijacking __signature__ python-wide sounds like it can cause other issues, if they need such a hack I would suggest finding a way (in pyside) to allow for mock to work.

I wonder though if this change in __signature__ will affect in any way any C extension that might not allow setting __signature__ if not set as a lack of __dict__ (I have not managed to find any issue with small examples though).

We only attempt to set __signature__ on Mocks, so I don't think extensions will be a problem.

I do think there's a bit of code smell on that method: it's called _check_* and then changes some attributes, that might be worth fixing?

Okay, I opened a bug in pyside tracker : https://bugreports.qt.io/browse/PYSIDE-1004

The jira issue in pyside2 is closed as fixed. I am closing this as third party.

stage: resolved