Issue36946
Created on 2019-05-17 05:48 by ZackerySpytz, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 13375 | merged | ZackerySpytz, 2019-05-17 05:58 | |
| PR 13376 | merged | miss-islington, 2019-05-17 07:14 | |
| PR 15639 | merged | hongweipeng, 2019-09-02 08:27 | |
| PR 15729 | merged | miss-islington, 2019-09-08 10:16 | |
| Messages (7) | |||
|---|---|---|---|
| msg342689 - (view) | Author: Zackery Spytz (ZackerySpytz) *  |
Date: 2019-05-17 05:48 | |
Python 3.8.0a4+ (heads/master:870b035bc6, May 16 2019, 20:53:02) [GCC 9.0.1 20190402 (experimental) [trunk revision 270074]] on linux Type "help", "copyright", "credits" or "license" for more information. >>> import sys >>> 'hi'[1::sys.maxsize] Objects/unicodeobject.c:14038:55: runtime error: signed integer overflow: 1 + 9223372036854775807 cannot be represented in type 'long int' 'i' >>> This is because unicode_subscript() performs an extra addition (cur += step) at the end of the for loop (which can overflow). The result of that final addition is not actually used. A patch to fix this issue was posted on #1621, but it seems that the patch has been abandoned. The bug is also described in detail in that issue. I have tweaked the patch and will open a PR. |
|||
| msg342690 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) *  |
Date: 2019-05-17 07:13 | |
New changeset 14514d9084a40f599c57da853a305aa264562a43 by Serhiy Storchaka (Zackery Spytz) in branch 'master': bpo-36946: Fix possible signed integer overflow when handling slices. (GH-13375) https://github.com/python/cpython/commit/14514d9084a40f599c57da853a305aa264562a43 |
|||
| msg342691 - (view) | Author: miss-islington (miss-islington) | Date: 2019-05-17 07:33 | |
New changeset f02d1a43c6be658cd279edb90e8e96c99e1127e7 by Miss Islington (bot) in branch '3.7': bpo-36946: Fix possible signed integer overflow when handling slices. (GH-13375) https://github.com/python/cpython/commit/f02d1a43c6be658cd279edb90e8e96c99e1127e7 |
|||
| msg350368 - (view) | Author: Batuhan Taskaya (BTaskaya) * |
Date: 2019-08-24 11:29 | |
Should we close this? |
|||
| msg351321 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2019-09-08 10:16 | |
New changeset 3c87a667bb367ace1de6bd1577fdb4f66947da52 by Serhiy Storchaka (HongWeipeng) in branch 'master': bpo-36946:Fix possible signed integer overflow when handling slices. (GH-15639) https://github.com/python/cpython/commit/3c87a667bb367ace1de6bd1577fdb4f66947da52 |
|||
| msg351323 - (view) | Author: miss-islington (miss-islington) | Date: 2019-09-08 10:36 | |
New changeset 021e5db20bc19d678a5b94247a5cdcf689eff006 by Miss Islington (bot) in branch '3.7': bpo-36946:Fix possible signed integer overflow when handling slices. (GH-15639) https://github.com/python/cpython/commit/021e5db20bc19d678a5b94247a5cdcf689eff006 |
|||
| msg351325 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2019-09-08 10:54 | |
Thank you Zackery and HongWeipeng for your contribution! |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:15 | admin | set | github: 81127 |
| 2019-09-08 10:54:41 | serhiy.storchaka | set | status: open -> closed resolution: fixed messages: + msg351325 stage: patch review -> resolved |
| 2019-09-08 10:36:41 | miss-islington | set | messages: + msg351323 |
| 2019-09-08 10:16:49 | miss-islington | set | pull_requests: + pull_request15383 |
| 2019-09-08 10:16:00 | serhiy.storchaka | set | messages: + msg351321 |
| 2019-09-02 08:27:13 | hongweipeng | set | pull_requests: + pull_request15305 |
| 2019-08-24 11:29:29 | BTaskaya | set | nosy:
+ BTaskaya messages: + msg350368 |
| 2019-05-17 07:33:13 | miss-islington | set | nosy:
+ miss-islington messages: + msg342691 |
| 2019-05-17 07:14:06 | miss-islington | set | pull_requests: + pull_request13287 |
| 2019-05-17 07:13:26 | serhiy.storchaka | set | nosy:
+ serhiy.storchaka messages: + msg342690 |
| 2019-05-17 05:58:50 | ZackerySpytz | set | keywords:
+ patch stage: patch review pull_requests: + pull_request13286 |
| 2019-05-17 05:48:44 | ZackerySpytz | create | |