I can't sort the result of iter_modules;
>>> import random, pkgutil
>>> modules = list(pkgutil.iter_modules(None))
>>> random.shuffle(modules)
>>> sorted(modules)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: '<' not supported between instances of 'FileFinder' and 'FileFinder'

I think dataclasses can be used to do it with order, frozen true parameters. Also a __getitem__ is required for doesnt break anything.

Unfortunately your change isn't backward compatible with the existing (namedtuple) version.

I expect this to fail in the dataclass version:
>>> finder, name, ispkg = list(pkgutil.iter_modules(None))[0]

And since this is an enhancement, it can only go in to 3.8. And the window is closing for that, so it's more likely to be 3.9, if we decide that backward compatibility isn't important here.

You're right. I am thinking implementing 4 sequence methods
(contains/len/iter/getitem) and set a depraction warning for them. We can
remove this methods in next relase

On Sun, May 19, 2019, 2:37 PM Eric V. Smith <report@bugs.python.org> wrote:

>
> Eric V. Smith <eric@trueblade.com> added the comment:
>
> Unfortunately your change isn't backward compatible with the existing
> (namedtuple) version.
>
> I expect this to fail in the dataclass version:
> >>> finder, name, ispkg = list(pkgutil.iter_modules(None))[0]
>
> And since this is an enhancement, it can only go in to 3.8. And the window
> is closing for that, so it's more likely to be 3.9, if we decide that
> backward compatibility isn't important here.
>
> ----------
> nosy: +eric.smith
> type:  -> enhancement
> versions:  -Python 3.6, Python 3.7
>
> _______________________________________
> Python tracker <report@bugs.python.org>
> <https://bugs.python.org/issue36962>
> _______________________________________
>

Can you review the PR, i implemented it there.

I'm not sure all of this churn is worth it for an unusual use case that can be satisfied by:

>>> sorted(pkgutil.iter_modules(None), key=lambda x: (x[1], x[2])

or even:

>>> sorted(pkgutil.iter_modules(None), key=operator.itemgetter(1))

(assuming that ispkg doesn't really need to be part of the key)

Before reviewing the patch, I suggest you raise the issue on python-dev and get some additional input.

I agree with Eric that this use case can be easily covered by using sorted(..., key=...).

I suggest closing this as 'rejected'.

Dataclasses are even more heavyweight than namedtuples. I am not sure that they should be used in the stdlib now. Especially in this case. I think the common use of iter_modules() is immediate unpacking of the yielded tuple:

    for importer, modname, ispkg in pkgutil.iter_modules():
        ...

Your change breaks it.

I agree with Eric and Berker that this issue should be closed.

I agree. Sorry, BTaskaya, but I just don't think the benefit of this change is worth the disruption.

stage: patch review -> resolved

messages: + msg342841

type: enhancement