test_urllib's test_geturl fails with following messege.

test_urllib
test test_urllib failed -- Traceback (most recent call last):
  File "/home/WhiteRabbit/python-dev/trunk/Lib/test/test_urllib.py",
line 84, in
 test_geturl
    self.assertEqual(self.returned_obj.geturl(), self.pathname)
AssertionError: 'file:///tmp/@test' != '/tmp/@test'

test_support.TESTFN is /tmp/@test on cygwin, and Lib/urllib.py(484,485)
specially cares about leading slash. 

            if file[:1] == '/':
                urlfile = 'file://' + file

If this is geturl()'s design, probably test should be changed like
attached patch.

I cannot create patch now, but test_site error comes from same reason.
>test_support.TESTFN is /tmp/@test on cygwin

After I applied following adhok patch, test passed.

Index: Lib/test/test_site.py
===================================================================
--- Lib/test/test_site.py       (revision 66385)
+++ Lib/test/test_site.py       (working copy)
@@ -126,7 +126,7 @@
 class PthFile(object):
     """Helper class for handling testing of .pth files"""

-    def __init__(self, filename_base=TESTFN, imported="time",
+    def __init__(self, filename_base="@test", imported="time",
                     good_dirname="__testdir__", bad_dirname="__bad"):
         """Initialize instance variables"""
         self.filename = filename_base + ".pth"

site.py's addpackage() is doing

    fullname = os.path.join(sitedir, name)

and on my cygwin, this equals to

    os.path.join(
        "/home/WhiteRabbit/python-dev/trunk/lib/test",
        "/tmp/@test.pth") #=> "/tmp/@test.pth"

probably this is not good. (I cannot figure out what site.py is doing
though)

Same happend in test_import.py too.

>test_support.TESTFN is /tmp/@test on cygwin
This was false information. There was a directry named @test, so
open(TESTFN, "w+") in test_support.py failed, "/tmp/@test" was used instead.

Several tests seem to assume TESTFN is relative path (filename?), so
maybe should we use @test2 as TESTFN if @test is not writable and vise
versa? (Or simply test fails if @test is not writable)

TESTFN will be in format "@test_{pid}_tmp" instead of "@test" right now.

So it's not easy to have exactly the same name "@test_{pid}_tmp" in case if you put "@test_{X}_tmp" (for X in range(1,100000)) so many files into the top folder.

does it need to keep open anymore?

To clarify Colin's comment (we worked on this at the sprints), in 2.7 and later regrtest no longer will generate a TESTFN that starts with /tmp in any circumstance, so that includes cygwin.  (Instead regrtest creates a temporary directory in which the tests are run.)  So, indeed, this bug is now out of date.

stage: needs patch -> resolved

type: behavior
stage: needs patch