Result object is null when a test case is skipeed.

You should justify the proposed change here on the issue, and see if the doc says anything about the issue either way.

I agree with Iman that this looks like a bug because the code updates the result object with skip info but then doesn't return it.

The patch needs a unit test covering this, as well as probably a doc update.

I'll add a documentation and unit test and update the PR.

It is a bug because there is a difference between the following cases:

    @skip("skipped")
    def test1(self):
        ...

    @other_decorator
    @skip("skipped")
    def test2(self):
        ...

    def test2(self):
        self.skipTest("skipped")
        ...

None is only returned in the first case. In other two cases a TestResult is returned with information about skipping.

It is obvious that it was unintentionally.

I just have fixed similar bug about calling stopTestRun() (issue44955).

Iman, please add tests and a NEWS entry. You can use tests added in issue44955 as an example.

New changeset 7e246a3a7b43762480ee4fe0cfb859e8e997a8c8 by Serhiy Storchaka in branch 'main':
bpo-41620: TestCase.run() now always return a TestResult instance (GH-28030)
https://github.com/python/cpython/commit/7e246a3a7b43762480ee4fe0cfb859e8e997a8c8

New changeset 0c5e0aa73f6f70d16d21ad9e1eb2d0fe3a334f0a by Miss Islington (bot) in branch '3.9':
bpo-41620: TestCase.run() now always return a TestResult instance (GH-28030) (GH-28065)
https://github.com/python/cpython/commit/0c5e0aa73f6f70d16d21ad9e1eb2d0fe3a334f0a

New changeset 243b8de0b15061704581974c0a27db1232a43b93 by Miss Islington (bot) in branch '3.10':
bpo-41620: TestCase.run() now always return a TestResult instance (GH-28030)
https://github.com/python/cpython/commit/243b8de0b15061704581974c0a27db1232a43b93

Thanks for the report and initial patch, Iman! ✨ 🍰 ✨  

And thanks Serhiy for pushing this across the finish line.

stage: patch review -> resolved

messages: + msg400061
stage: test needed

messages: + msg393489