Issue44477
Created on 2021-06-21 16:08 by kj, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 26833 | closed | kj, 2021-06-21 16:09 | |
| Messages (3) | |||
|---|---|---|---|
| msg396264 - (view) | Author: Ken Jin (kj) *  |
Date: 2021-06-21 16:08 | |
issue44206, issue44337, and issue44338 converted things dependent on ma_version_tag to ma_keys->dk_version. I propose to remove ma_version_tag and save 8 bytes of space in dict. I've prepared a draft PR to do that. However, I'd like to wait for some time before merging it. This will make it easier to revert a PR in one of those issues should the need arise. |
|||
| msg396268 - (view) | Author: Ken Jin (kj) * |
Date: 2021-06-21 16:24 | |
Hmm I'm suddenly having second thoughts. I wonder if there's future use cases I might be missing here from PEP 509? |
|||
| msg396276 - (view) | Author: Ken Jin (kj) * |
Date: 2021-06-21 17:27 | |
Closing this for now as it seems PEP 509 may need to be repealed: https://github.com/faster-cpython/ideas/issues/30#issuecomment-858615678 Sorry for the noise everyone :(. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:47 | admin | set | github: 88643 |
| 2021-06-21 17:27:16 | kj | set | status: open -> closed resolution: postponed messages: + msg396276 stage: patch review -> resolved |
| 2021-06-21 16:24:32 | kj | set | nosy:
+ vstinner messages: + msg396268 |
| 2021-06-21 16:09:15 | kj | set | keywords:
+ patch stage: patch review pull_requests: + pull_request25414 |
| 2021-06-21 16:08:34 | kj | create | |