Issue 47196: Function pointer cast in test_imp
Created on 2022-04-02 00:01 by hoodchatham, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 32244 | merged | hoodmane, 2022-04-02 00:02 | |
| PR 32280 | merged | hoodmane, 2022-04-03 04:25 | |
| Messages (4) | |||
|---|---|---|---|
| msg416524 - (view) | Author: Hood Chatham (hoodchatham) * | Date: 2022-04-02 00:01 | |
The function PyInit_imp_dummy is declared as void f(PyObject* spec) and ignores the argument. In the test, it is called via imp.load_dynamic as void f(void). On wasm targets without the call trampolines added in https://bugs.python.org/issue47162 this causes a fatal error. (There's a bit more discussion about this issue in that thread.) |
|||
| msg416525 - (view) | Author: Hood Chatham (hoodchatham) * | Date: 2022-04-02 00:25 | |
Every other `PyInit` function in that module also needs the spec argument to be removed in order for test_importlib to pass. |
|||
| msg416540 - (view) | Author: miss-islington (miss-islington) | Date: 2022-04-02 08:00 | |
New changeset 7000cd70164707e28ba045b5c036ca7ed73f5dc4 by Hood Chatham in branch 'main': bpo-47196: Fix function pointer cast in test_imp (GH-32244) https://github.com/python/cpython/commit/7000cd70164707e28ba045b5c036ca7ed73f5dc4 |
|||
| msg416614 - (view) | Author: miss-islington (miss-islington) | Date: 2022-04-03 07:45 | |
New changeset 3faa9f78d4b9a8c0fd4657b434bdb08ae1f28800 by Hood Chatham in branch 'main': bpo-47196: Fix one more PyInit function signature (GH-32280) https://github.com/python/cpython/commit/3faa9f78d4b9a8c0fd4657b434bdb08ae1f28800 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:58 | admin | set | github: 91352 |
| 2022-04-03 21:01:24 | christian.heimes | set | status: open -> closed versions: + Python 3.11 resolution: fixed components: + Tests type: enhancement stage: patch review -> resolved |
| 2022-04-03 21:00:45 | christian.heimes | link | issue40280 dependencies |
| 2022-04-03 07:45:36 | miss-islington | set | messages: + msg416614 |
| 2022-04-03 04:25:00 | hoodmane | set | pull_requests: + pull_request30341 |
| 2022-04-02 08:00:58 | miss-islington | set | nosy:
+ miss-islington messages: + msg416540 |
| 2022-04-02 00:25:32 | hoodchatham | set | messages: + msg416525 |
| 2022-04-02 00:02:59 | hoodmane | set | keywords:
+ patch nosy: + hoodmane pull_requests:
+ pull_request30315 |
| 2022-04-02 00:01:51 | hoodchatham | create | |