Issue7695
Created on 2010-01-13 20:02 by conorh, last changed 2022-04-11 14:56 by admin.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| patch_termios_consts_issue7695.diff | Rodolpho.Eckhardt, 2010-12-11 17:02 | review | ||
| Messages (5) | |||
|---|---|---|---|
| msg97736 - (view) | Author: Conor Hughes (conorh) | Date: 2010-01-13 20:02 | |
Module termios is missing some constants useful for handling control characters under Mac OS X (and Solaris, and probably BSD but I don't have a pure BSD system to test against). In particular, these systems support a control character "DSUSP" (which is similar to SUSP), but there is no provided symbol for the index into the cc array to use. The correct value for the proposed termios.VDSUSP would be 11 on MacOS and Solaris. I'm no Linux wizard but I don't believe it has this control character. In addition, MacOS supports a control character STATUS, and the correct value for the proposed termios.VSTATUS would be 18. Likewise, _POSIX_VDISABLE (or some similar identifier) is missing from the module. I believe the correct value on Solaris would be '\x00', MacOS '\xff', Linux '\x00'. |
|||
| msg97749 - (view) | Author: Conor Hughes (conorh) | Date: 2010-01-14 02:35 | |
As these aren't POSIX, changing to feature request. |
|||
| msg123803 - (view) | Author: Rodolpho Eckhardt (Rodolpho.Eckhardt) | Date: 2010-12-11 17:02 | |
Because these constants might not exist on all platforms, the patch uses ifdef's around them. |
|||
| msg174714 - (view) | Author: A.M. Kuchling (akuchling) *  |
Date: 2012-11-03 22:21 | |
Patch seems clearly correct; compiles & works on MacOS. We could just apply this. |
|||
| msg174727 - (view) | Author: Christian Heimes (christian.heimes) * |
Date: 2012-11-04 00:42 | |
The patch looks good to me but it's missing doc updates. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:56:56 | admin | set | github: 51944 |
| 2014-12-31 16:20:36 | akuchling | set | nosy:
- akuchling |
| 2012-11-04 00:42:59 | christian.heimes | set | nosy:
+ christian.heimes messages: + msg174727 |
| 2012-11-03 22:21:38 | akuchling | set | nosy:
+ akuchling messages:
+ msg174714 |
| 2011-11-19 14:10:01 | pitrou | set | nosy:
+ vstinner versions: - Python 2.7, Python 3.2 |
| 2011-11-19 14:06:55 | ezio.melotti | set | stage: needs patch -> patch review versions: + Python 3.3 |
| 2010-12-11 17:02:35 | Rodolpho.Eckhardt | set | files:
+ patch_termios_consts_issue7695.diff nosy:
+ Rodolpho.Eckhardt keywords: + patch |
| 2010-01-14 04:06:24 | brian.curtin | set | priority: normal stage: needs patch versions: + Python 2.7, Python 3.2, - Python 2.6, Python 2.5 |
| 2010-01-14 02:35:23 | conorh | set | type: behavior -> enhancement messages: + msg97749 |
| 2010-01-13 20:02:29 | conorh | create | |