Message 183720 - Python tracker

Message183720

Author	vstinner
Recipients	ezio.melotti, moijes12, serhiy.storchaka, vstinner
Date	2013-03-08.01:42:57
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1362706978.32.0.983779579105.issue16321@psf.upfronthosting.co.za>
In-reply-to

Content
I don't understand why do we have specialized functions to compare strings. Can't we reuse PyUnicode_Compare(a, b) or PyUnicode_RichCompare( a, b, Py_EQ)? Is unicode_eq() used to inline the code? By the way, unicode_compare_eq() (subfunction of these functions) and unicode_eq() have a different implementation. unicode_eq() checks the first byte before calling memcmp(). We should only have one implementation, the fastest if possible :-) See also issue #16286.

Content

I don't understand why do we have specialized functions to compare strings. Can't we reuse PyUnicode_Compare(a, b) or PyUnicode_RichCompare( a, b, Py_EQ)? Is unicode_eq() used to inline the code?

By the way, unicode_compare_eq() (subfunction of these functions) and unicode_eq() have a different implementation. unicode_eq() checks the first byte before calling memcmp(). We should only have one implementation, the fastest if possible :-)

See also issue #16286.

History
Date	User	Action	Args
2013-03-08 01:42:58	vstinner	set	recipients: + vstinner, ezio.melotti, serhiy.storchaka, moijes12
2013-03-08 01:42:58	vstinner	set	messageid: <1362706978.32.0.983779579105.issue16321@psf.upfronthosting.co.za>
2013-03-08 01:42:58	vstinner	link	issue16321 messages
2013-03-08 01:42:57	vstinner	create