The Objects/stringlib directory used for "templates" which instantiates for specified bytes or unicode kinds. Objects/stringlib/eq.h has no relation to this "templates" and should be moved out (as Objects/unicode_eq.h for example).

Also it should be removed from Include/Python.h. It used only in Objects/dictobject.c and Objects/setobject.c, and included there directly.

Changes made according to the Sehiy's last comment. Include/Python.h has not been modified as it doesn't need one. Also, make files have been changed.

I don't understand why do we have specialized functions to compare strings. Can't we reuse PyUnicode_Compare(a, b) or PyUnicode_RichCompare( a, b, Py_EQ)? Is unicode_eq() used to inline the code?

By the way, unicode_compare_eq() (subfunction of these functions) and unicode_eq() have a different implementation. unicode_eq() checks the first byte before calling memcmp(). We should only have one implementation, the fastest if possible :-)

See also issue #16286.

Issue #17628 proposes a patch which reuses unicode_eq() in PyUnicode_RichCompare.

Some of this cleanup was done but we still have unicode_eq in Objects/stringlib/eq.h which is only used in Objects/dictobject.c.

To add irit's comment, It is *also* used in Objects/unicodeobject.c

The remaining unicode_eq can be left as-is.   While it is only in dictobject.c, the requisite knowledge of string internals makes it reasonable to keep it in stringlib.

stage: needs patch -> resolved

messages: + msg396223

keywords: + easy (C), - patch

nosy: + moijes12
messages: + msg183646

keywords: + patch