Remove `restoreKeys` to clear cache after update by schuenadel · Pull Request #285 · actions/setup-java
Navigation Menu
{{ message }}
actions / setup-java Public
- Notifications You must be signed in to change notification settings
- Fork 834
Merged
marko-zivic-93 merged 3 commits intoactions:mainfrom
Jul 15, 2022Merged
Conversation
Copy link
Contributor
schuenadel
commented
Jan 25, 2022
schuenadel
commented
Description:
Suggestion (like commented here) to remove fallback hash key to avoid keeping dependencies "forever". Start with a completely clean cache whenever any dependency changes.
Related issue:
#269
Check list:
- Mark if documentation changes are required.
- Mark if tests were added or updated to cover the changes.
schuenadel
mentioned this pull request
5 tasks
schuenadel
changed the title
Remove "restoreKeys" to clear cache after update
Remove restoreKeys to clear cache after update
Copy link
Contributor
dmitry-shibanov
commented
Apr 18, 2022
dmitry-shibanov commented
Apr 18, 2022Hello @schuenadel. Could you please sync with the main branch ?
schuenadel
requested a review
from a team
Copy link
Contributor Author
schuenadel
commented
Apr 19, 2022
schuenadel commented
Apr 19, 2022@dmitry-shibanov done ✅
…-after-dependency-update
marko-zivic-93 approved these changes Jul 14, 2022
marko-zivic-93
merged commit
9e9f60b
into
actions:main
gustavovnicius
mentioned this pull request
Copy link
paramaggarwal
commented
Aug 19, 2022
paramaggarwal commented
Aug 19, 2022This is a bad change, this effectively makes caching useless when the linked file like pom.xml has even a tiny change.
Copy link
thomasmey
commented
Aug 29, 2024
thomasmey commented
Aug 29, 2024Yes, setup-java should use a per build system strategy for setting the restore-keys, for maven build system this change is really bad
tdfacer pushed a commit to ifit/setup-java that referenced this pull request
Oct 7, 2025…ter-dependency-update Remove `restoreKeys` to clear cache after update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants