Home Original page

fix(language-service): Only provide dom completions for inline templates by atscott · Pull Request #41078 · angular/angular

@atscott 

We currently provide completions for DOM elements in the schema as well
as attributes when we are in the context of an external template.
However, these completions are already provided by other extensions for
HTML contexts (like Emmet). To avoid duplication of results, this commit
updates the language service to exclude DOM completions for external
templates. They are still provided for inline templates because those
are not handled by the HTML language extensions.

@kyliau kyliau added action: merge

The PR is ready for merge by the caretaker

and removed action: review

The PR is still awaiting reviews from at least one requested reviewer

labels

Mar 4, 2021

AndrewKushnir pushed a commit that referenced this pull request

Mar 4, 2021 
…tes (#41078)

We currently provide completions for DOM elements in the schema as well
as attributes when we are in the context of an external template.
However, these completions are already provided by other extensions for
HTML contexts (like Emmet). To avoid duplication of results, this commit
updates the language service to exclude DOM completions for external
templates. They are still provided for inline templates because those
are not handled by the HTML language extensions.

PR Close #41078

This was referenced

Mar 10, 2021

This was referenced

Mar 15, 2021