Home Original page

perf(compiler): reduce amount of generated code for safe accesses and nullish coalescing by crisbeto · Pull Request #41563 · angular/angular

@crisbeto crisbeto marked this pull request as ready for review

April 11, 2021 08:50

petebacondarwin

AndrewKushnir

@crisbeto 

… nullish coalescing

This is follow-up from angular#41437 and it reduces the amount of code we generate for safe property accesses (`a?.b`) and nullish coalescing (`a ?? b`) by:
1. Reusing variables in nested nullish coalescing expressions.
2. Not initializing temporary variables to `null`. The way our code is generated means that the value will always be overwritten before we compare against it so the initializer didn't really matter.

Fixes angular#41491.

@zarend zarend added target: rc

This PR is targeted for the next release-candidate

and removed target: major

This PR is targeted for the next major release

labels

Apr 14, 2021

zarend pushed a commit that referenced this pull request

Apr 14, 2021 
… nullish coalescing (#41563)

This is follow-up from #41437 and it reduces the amount of code we generate for safe property accesses (`a?.b`) and nullish coalescing (`a ?? b`) by:
1. Reusing variables in nested nullish coalescing expressions.
2. Not initializing temporary variables to `null`. The way our code is generated means that the value will always be overwritten before we compare against it so the initializer didn't really matter.

Fixes #41491.

PR Close #41563