Remove options from `Builder#parse_file` & `Builder#load_file`. by ioquatix · Pull Request #1663 · rack/rack

@ioquatix

@ioquatix

@ioquatix

There are lots of tests that write app, _ = Builder.parse_file. I've left them. The _ now becomes nil which I think is acceptable for backwards compatibility.

Can you see anything else we need to do?

cc @tenderlove

jeremyevans

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

This was referenced

Mar 8, 2021

This was referenced

Mar 15, 2021

This was referenced

Mar 17, 2021

msz-kp added a commit to msz-kp/padrino-framework that referenced this pull request

Mar 13, 2024

msz-kp added a commit to msz-kp/padrino-framework that referenced this pull request

Mar 13, 2024