Add missing exceptions flag for Linux compilation by tbazin · Pull Request #12 · 2bbb/node-abletonlink
Navigation Menu
{{ message }}
2bbb / node-abletonlink Public
- Notifications You must be signed in to change notification settings
- Fork 16
Merged
Add missing exceptions flag for Linux compilation#12
2bbb merged 1 commit into2bbb:masterfrom
Add missing exceptions flag for Linux compilation#12
2bbb merged 1 commit into2bbb:masterfrom
Conversation
Copy link Copy Markdown
Contributor
tbazin
commented
Jul 8, 2020
tbazin
commented
Added missing flag for exception enabling.
Note that I also suspect that the NAPI_ENABLE_CPP_EXCEPTIONS environment variable should be replaced with NAPI_CPP_EXCEPTIONS according to the node-addon-api sources:
https://github.com/nodejs/node-addon-api/blob/ef16dfb4a2f7efbb2bd5704a517b383c98c5a3c7/napi.h#L28
Added missing flag for exception enabling
tbazin
changed the title
Add missing exceptions flag for linux compilation
Add missing exceptions flag for Linux compilation
2bbb
merged commit
90fecdc
into
2bbb:master
Copy link Copy Markdown
Owner
2bbb
commented
Jul 9, 2020
2bbb commented
Jul 9, 2020@tbazin
thanks!!
Copy link Copy Markdown
Owner
2bbb
commented
Jul 15, 2020
2bbb commented
Jul 15, 2020@tbazin
i forgot to publish...
and, now this version published@v0.1.1!
thx!
Copy link Copy Markdown
Contributor Author
tbazin
commented
Jul 22, 2020
tbazin commented
Jul 22, 2020Thanks for publishing it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment