Add missing exceptions flag for Linux compilation by tbazin · Pull Request #12 · 2bbb/node-abletonlink

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@tbazin

Copy link Copy Markdown

Contributor

@tbazin tbazin commented

Jul 8, 2020

Added missing flag for exception enabling.

Note that I also suspect that the NAPI_ENABLE_CPP_EXCEPTIONS environment variable should be replaced with NAPI_CPP_EXCEPTIONS according to the node-addon-api sources:
https://github.com/nodejs/node-addon-api/blob/ef16dfb4a2f7efbb2bd5704a517b383c98c5a3c7/napi.h#L28

Added missing flag for exception enabling

@tbazin tbazin changed the title Add missing exceptions flag for linux compilation Add missing exceptions flag for Linux compilation

Jul 8, 2020

@2bbb 2bbb merged commit 90fecdc into 2bbb:master

Jul 9, 2020

@2bbb

Copy link Copy Markdown

Owner

2bbb commented

Jul 9, 2020

@tbazin
thanks!!

@2bbb

Copy link Copy Markdown

Owner

2bbb commented

Jul 15, 2020

@tbazin
i forgot to publish...
and, now this version published@v0.1.1!

thx!

tbazin reacted with heart emoji

@tbazin

Copy link Copy Markdown

Contributor Author

tbazin commented

Jul 22, 2020

Thanks for publishing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tbazin @2bbb