Fix #725 - correctly parse tags on json import by hannah98 · Pull Request #908 · ArchiveBox/ArchiveBox
Navigation Menu
{{ message }}
ArchiveBox / ArchiveBox Public
- Notifications You must be signed in to change notification settings
- Fork 1.5k
Merged
Fix #725 - correctly parse tags on json import#908
pirate merged 1 commit intoArchiveBox:devfrom
hannah98:dev
Fix #725 - correctly parse tags on json import#908
pirate merged 1 commit intoArchiveBox:devfrom
hannah98:dev
Conversation
Copy link
Contributor
hannah98
commented
Dec 20, 2021
hannah98
commented
Summary
This PR fixes #725 - instead of tags being split on each character, this fix mimics a code block further down in the same file to create a list of tags first before calling the save_tags() method.
ArchiveBox/archivebox/index/sql.py
Lines 107 to 109 in 3276434
| tag_set = ( | |
| set(tag.strip() for tag in (link.tags or '').split(',')) | |
| ) |
Related issues
Changes these areas
- Bugfixes
- Feature behavior
- Command line interface
- Configuration options
- Internal architecture
- Snapshot data layout on disk
Copy link
lgtm-com
bot
commented
Dec 20, 2021
lgtm-com bot commented
Dec 20, 2021This pull request introduces 1 alert when merging 4b8962b into 9899377 - view on LGTM.com
new alerts:
- 1 for Unused local variable
Copy link
Member
pirate
commented
Dec 21, 2021
pirate commented
Dec 21, 2021Thanks @hannah98 !!!
pirate
merged commit
f363738
into
ArchiveBox:dev
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants