add options parameter to validate by zoren · Pull Request #52 · AssemblyScript/wabt.js

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@zoren

Copy link Copy Markdown

@zoren zoren commented

Dec 8, 2024

This fixes #51

@charlieroberts

Copy link Copy Markdown

I lost some time not realizing validate needed to be passed WasmFeatures; this pull request and the corresponding issue are the only things that stopped me from concluding validation was broken when using shared memory. Thanks to @zoren and it should certainly be merged (and the README should be updated as well).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

validate missing optional options parameter

2 participants

@zoren @charlieroberts