add the missing headers in windows by flutter-painter · Pull Request #1482 · Baseflow/flutter-permission-handler
Navigation Menu
{{ message }}
Baseflow / flutter-permission-handler Public
- Notifications You must be signed in to change notification settings
- Fork 937
Open
add the missing headers in windows#1482
flutter-painter wants to merge 4 commits intoBaseflow:mainfrom
add the missing headers in windows#1482
flutter-painter wants to merge 4 commits intoBaseflow:mainfrom
Conversation
Copy link Copy Markdown
Fixed the windows compatibility issue
Pre-launch Checklist
- I made sure the project builds.
- I read the Contributor Guide and followed the process outlined there for submitting PRs.
- [ x I updated
pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is does not need version changes. - I updated
CHANGELOG.mdto add a description of the change. - I updated/added relevant documentation (doc comments with
///). - I rebased onto
main. -> rebase what ? - I added new tests to check the change I am making, or this PR does not need tests.
-> No need, here we simply fix the bloody thing - I made sure all existing and new tests are passing.
- I ran
dart format .and committed any changes. - I ran
flutter analyzeand fixed any errors.
flutter-painter added 2 commits
July 8, 2025 20:04Copy link Copy Markdown
Author
flutter-painter
commented
Jul 8, 2025
flutter-painter commented
Jul 8, 2025Hi @ened
Could you please review ?
flutter-painter added 2 commits
July 8, 2025 20:43…permission_handler_plugin.h (compatibility header) Updated: permission_handler_windows/windows/CMakeLists.txt (added compatibility header to build)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment