Standardize min scene length message across detectors by Janscode · Pull Request #438 · Breakthrough/PySceneDetect

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@Janscode

Copy link Copy Markdown

Contributor

@Janscode Janscode commented

Oct 15, 2024

edited

Loading

I found the min_scene_length docs to be a little confusing for the AdaptiveDetector class, I think it's helpful to know 1) the value is in frames and 2) scenes won't be filtered out / dropped, instead they are merged

@Breakthrough Breakthrough self-assigned this

Oct 16, 2024

@Breakthrough

Copy link Copy Markdown

Owner

Thanks for improving this.

@Breakthrough Breakthrough added this to the 0.6.5 milestone

Oct 16, 2024

@Breakthrough Breakthrough merged commit 7c79872 into Breakthrough:main

Oct 19, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Breakthrough Breakthrough Breakthrough approved these changes

Labels

None yet

Projects

None yet

Milestone

0.6.5

Development

Successfully merging this pull request may close these issues.

2 participants

@Janscode @Breakthrough