Fix/number check by emanuel-schmid · Pull Request #1089 · CLIMADA-project/climada_python
Navigation Menu
{{ message }}
CLIMADA-project / climada_python Public
- Notifications You must be signed in to change notification settings
- Fork 151
Merged
Conversation
Copy link
Collaborator
Changes proposed in this PR:
- after upgrading geopandas and pandas two integration tests failed due to incomparable types, float and numpy.float32
This PR fixes this
PR Author Checklist
- Read the Contribution Guide
- Correct target branch selected (if unsure, select
develop) - Descriptive pull request title added
- Source branch up-to-date with target branch
- Documentation updated
- Tests updated
- Tests passing
- No new linter issues
- Changelog updated
PR Reviewer Checklist
- Read the Contribution Guide
- CLIMADA Reviewer Checklist passed
- Tests passing
- No new linter issues
emanuel-schmid
requested review from
chahank and
peanutfun
as code owners
emanuel-schmid
changed the base branch from
main
to
develop
Copy link
Collaborator Author
emanuel-schmid
commented
Aug 27, 2025
emanuel-schmid commented
Aug 27, 2025test fails because of an additional line in climada.test
emanuel-schmid
deleted the
fix/number-check
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment