Collaborator

Changes proposed in this PR:
ImpactCalc.impact(exposures, impfset, hazard) checks that

• exposures refers to impact functions for the given hazard type
• impfset contains impact functions for the given hazard type.
  In case of mismatching hazard types, a comprehensible error message is produced. Currently, these cases result in the cryptic error message AttributeError: 'list' has no attribute 'calc_mdr'

This PR fixes #669

PR Author Checklist

• Read the Contribution Guide
• Correct target branch selected (if unsure, select develop)
• Descriptive pull request title added
• Source branch up-to-date with target branch
• Documentation updated
• Tests updated
• Tests passing
• No new linter issues
• Changelog updated

PR Reviewer Checklist

• Read the Contribution Guide
• CLIMADA Reviewer Checklist passed
• Tests passing
• No new linter issues

…g hazard types

updated CHANGELOG.md

2aff5ad

resolve new linter issues

faaeaeb

chahank reviewed Apr 6, 2023

View reviewed changes

chahank reviewed Apr 6, 2023

View reviewed changes

chahank reviewed Apr 6, 2023

View reviewed changes

chahank reviewed Apr 6, 2023

View reviewed changes

Member

Great solution to issue #669 ! Thanks! Just a few suggestion to make the test more efficient and clearer.

Collaborator

I ran into this error today. An hour later I'm here and very pleased to see this fix ✨

Collaborator Author

Thank you for the review! I think I addressed all your comments. Please merge the branch If you agree.

chahank reviewed Apr 17, 2023

View reviewed changes

chahank reviewed Apr 17, 2023

View reviewed changes

chahank reviewed Apr 17, 2023

View reviewed changes

chahank reviewed Apr 17, 2023

View reviewed changes

updated creation of test objects (exp and impfset)

3d8c5b2

updated exposure creation for test

3dac142

Member

Great, thanks! Ready to merge imho.

Member

Welcome to the authors list!

Improve impact calc error messages #669