Use Pytest for running tests by peanutfun · Pull Request #726

Use Pytest for running tests by peanutfun · Pull Request #726 · CLIMADA-project/climada_python

Conversation

NOTE: Revert this change once the Jenkins environment is updated

peanutfun marked this pull request as ready for review

May 30, 2023 12:02

		.PHONY : install_test
		install_test : ## Test installation was successful
		python tests_install.py report
		pytest $(PYTEST_JUNIT_ARGS) climada/engine/test/test_cost_benefit.py \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for the future: we should probably make a better install test. If there is already one around, I would propose to switch now.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a particular integration test in mind that would be suitable for that?

Looks all very reasonable and useful. However, I cannot gauge the code on a technical level. @emanuel-schmid : could you please have a look and confirm the review?

# Conflicts:
#	CHANGELOG.md

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good to me