Reassign centroids by default by chahank · Pull Request #730 · CLIMADA-project/climada_python
Navigation Menu
{{ message }}
CLIMADA-project / climada_python Public
- Notifications You must be signed in to change notification settings
- Fork 151
Merged
Conversation
Copy link
Member
Changes proposed in this PR:
- The new functioning of the method
Exposures.affected_valuedefined in Feature/change impact total value #702 has been update to reassign centroids by default.
PR Author Checklist
- Read the Contribution Guide
- Correct target branch selected (if unsure, select
develop) - Descriptive pull request title added
- Source branch up-to-date with target branch
- Documentation updated
- Tests updated
- Tests passing
- No new linter issues
- Changelog updated
PR Reviewer Checklist
- Read the Contribution Guide
- CLIMADA Reviewer Checklist passed
- Tests passing
- No new linter issues
Chahan Kropf added 2 commits
May 24, 2023 17:42
chahank
requested a review
from peanutfun
peanutfun approved these changes May 25, 2023
Copy link
Member
peanutfun
left a comment
peanutfun
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this fix! 🙌 I'll run 'black' to format the changes and then merge
peanutfun added 2 commits
May 25, 2023 13:58Make update to affected_total_value a single message.
peanutfun
merged commit
b67314a
into
develop
emanuel-schmid
deleted the
bugfix/exposed_value
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants