Set save_mat=False by chahank · Pull Request #746 · CLIMADA-project/climada_python
Navigation Menu
{{ message }}
CLIMADA-project / climada_python Public
- Notifications You must be signed in to change notification settings
- Fork 151
Merged
Conversation
Copy link
Member
Changes proposed in this PR:
- This sets the variable
ImpactCalc.impact(save_mat=False)toFalsein theunsequamodule only. Since the change to theImpactCalcclass, the default was changed fromFalsetoTrue, thus it needs to be set explicitly now. This is important as it cost memory and computation time, while the information cannot be processed in theunsequamodule at the moment.
PR Author Checklist
- Read the Contribution Guide
- Correct target branch selected (if unsure, select
develop) - Descriptive pull request title added
- Source branch up-to-date with target branch
- Documentation updated
- Tests updated
- Tests passing
- No new linter issues
- Changelog updated
PR Reviewer Checklist
- Read the Contribution Guide
- CLIMADA Reviewer Checklist passed
- Tests passing
- No new linter issues
chahank
requested a review
from peanutfun
Copy link
Member Author
chahank
commented
Jul 5, 2023
chahank commented
Jul 5, 2023If you accept the fix, I will update the changelog.
peanutfun requested changes Jul 6, 2023
Copy link
Member
peanutfun
left a comment
peanutfun
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chahank Can you clarify in the PR description that this only affects the Unsequa module? Also, a Changelog entry is missing 🙃 Apart from that, everything looks good! 👌
chahank
merged commit
b4cafc1
into
develop
emanuel-schmid
deleted the
bugfix/unsequa_save_mat_true
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment