Remove Tag attribute from ImpactFuncSet by emanuel-schmid · Pull Request #753 · CLIMADA-project/climada_python
Navigation Menu
{{ message }}
CLIMADA-project / climada_python Public
- Notifications You must be signed in to change notification settings
- Fork 151
Merged
Remove Tag attribute from ImpactFuncSet#753
Remove Tag attribute from ImpactFuncSet#753
Conversation
Copy link
Collaborator
Changes proposed in this PR:
- simply remove the attribute, leaving out any descriptions when initializing an object
This PR fixes #
PR Author Checklist
- Read the Contribution Guide
- Correct target branch selected (if unsure, select
develop) - Descriptive pull request title added
- Source branch up-to-date with target branch
- Documentation updated
- Tests updated
- Tests passing
- No new linter issues
- Changelog updated
PR Reviewer Checklist
- Read the Contribution Guide
- CLIMADA Reviewer Checklist passed
- Tests passing
- No new linter issues
emanuel-schmid added 2 commits
July 12, 2023 13:50
emanuel-schmid
changed the base branch from
main
to
develop
peanutfun requested changes Jul 12, 2023
Copy link
Member
peanutfun
left a comment
peanutfun
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Again, the tutorial still mentions the tag and needs to be updated
emanuel-schmid added 2 commits
July 12, 2023 18:12# Conflicts: # climada/entity/entity_def.py
peanutfun approved these changes Jul 13, 2023
peanutfun
merged commit
4e01450
into
develop
emanuel-schmid
deleted the
feature/remove_tags_impfset
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants