Fix dist_approx with "geosphere" method and close points by tovogt · Pull Request #792 · CLIMADA-project/climada_python
Navigation Menu
{{ message }}
CLIMADA-project / climada_python Public
- Notifications You must be signed in to change notification settings
- Fork 151
Merged
Fix dist_approx with "geosphere" method and close points#792
emanuel-schmid merged 3 commits intodevelopfrom
Fix dist_approx with "geosphere" method and close points#792
emanuel-schmid merged 3 commits intodevelopfrom
Conversation
Copy link
Collaborator
Changes proposed in this PR:
- Fix the
dist_approxutil function when used withmethod="geosphere"andlog=True. - This only affects very small input values, i.e. computing the distance between points that are very close. I added a unit test for that case. I also added a test case where points are identical because I think that this is a kind of sanity check that should be included.
PR Author Checklist
- Read the Contribution Guide
- Correct target branch selected (if unsure, select
develop) - Descriptive pull request title added
- Source branch up-to-date with target branch
- Documentation updated
- Tests updated
- Tests passing
- No new linter issues
- Changelog updated
PR Reviewer Checklist
- Read the Contribution Guide
- CLIMADA Reviewer Checklist passed
- Tests passing
- No new linter issues
Thomas Vogt added 2 commits
September 25, 2023 10:55
tovogt
changed the title
Feature/fix dist approx geosphere
Fix dist_approx with "geosphere" method and close points
chahank
requested a review
from viggowat
climada/util/test/test_coordinates.py
Show resolved
Hide resolved
climada/util/test/test_coordinates.py Show resolved Hide resolved
Copy link
Collaborator
emanuel-schmid
commented
Oct 24, 2023
emanuel-schmid commented
Oct 24, 2023Looks good to me. Obviously fixes a bug.
emanuel-schmid
merged commit
f362c2b
into
develop
emanuel-schmid
deleted the
feature/fix_dist_approx_geosphere
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants