Encourage contributions in README and CONTRIBUTING by peanutfun · Pull Request #797 · CLIMADA-project/climada_python
Navigation Menu
{{ message }}
CLIMADA-project / climada_python Public
- Notifications You must be signed in to change notification settings
- Fork 151
Merged
Encourage contributions in README and CONTRIBUTING#797
Encourage contributions in README and CONTRIBUTING#797
Conversation
Copy link
Member
Changes proposed in this PR:
- Be more encouraging about contributing to CLIMADA in
README.mdandCONTRIBUTING.md. - Add a list and explanation of possible contributions.
PR Author Checklist
- Read the Contribution Guide
- Correct target branch selected (if unsure, select
develop) - Descriptive pull request title added
- Source branch up-to-date with target branch
[ ] Documentation updated[ ] Tests updated- Tests passing
- No new linter issues
- Changelog updated
PR Reviewer Checklist
- Read the Contribution Guide
- CLIMADA Reviewer Checklist passed
- Tests passing
- No new linter issues
Update README.md and CONTRIBUTING.md accordingly.
peanutfun
requested review from
chahank and
sarah-hlsn
sarah-hlsn reviewed Oct 27, 2023
CONTRIBUTING.md
Outdated
Show resolved
Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
peanutfun added 2 commits
October 27, 2023 11:41chahank reviewed Oct 27, 2023
CONTRIBUTING.md
Outdated
Show resolved
Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
chahank reviewed Oct 27, 2023
CONTRIBUTING.md
Outdated
Show resolved
Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Member
chahank
commented
Oct 27, 2023
chahank commented
Oct 27, 2023Happy, thanks!
peanutfun and others added 3 commits
November 3, 2023 13:53Co-authored-by: Chahan M. Kropf <chahan.kropf@usys.ethz.ch>
peanutfun
requested a review
from chahank
Copy link
Member
chahank
commented
Nov 3, 2023
chahank commented
Nov 3, 2023The changelog has now a conflict :D But otherwise feel free to merge!
Copy link
Member Author
peanutfun
commented
Nov 6, 2023
peanutfun commented
Nov 6, 2023Done. Builds have been passing, no Python files were changed. Merging now.
peanutfun
merged commit
240dafa
into
develop
emanuel-schmid
deleted the
more-contributions
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants