Fix the exception tests for the latest version of xarray by peanutfun · Pull Request #827 · CLIMADA-project/climada_python

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@peanutfun

Copy link

Member

@peanutfun peanutfun commented

Dec 12, 2023

edited

Loading

Changes proposed in this PR:

  • Update the tests because the latest version of xarray (?) changed the error messages slightly

PR Author Checklist

PR Reviewer Checklist

@peanutfun

Copy link

Member Author

peanutfun commented

Dec 12, 2023

edited

Loading

@emanuel-schmid We should update the environment on Jenkins to make sure that the nightly tests also pass. After merging this, the tests will fail for older versions of xarray.

Edit: Not needed anymore. Code should now work with both versions

@peanutfun

Copy link

Member Author

@emanuel-schmid The tests should now work for both the new and the older versions 🙌

emanuel-schmid reacted with hooray emoji

@chahank

Copy link

Member

chahank commented

Dec 13, 2023

I would then merge or do you want to have another look @peanutfun @emanuel-schmid ?

@emanuel-schmid emanuel-schmid merged commit e81249f into develop

Dec 13, 2023

@emanuel-schmid emanuel-schmid deleted the bigfix/xarray-exceptions-tests branch

December 13, 2023 12:59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chahank chahank Awaiting requested review from chahank chahank is a code owner

@emanuel-schmid emanuel-schmid Awaiting requested review from emanuel-schmid emanuel-schmid is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@peanutfun @chahank @emanuel-schmid