Fix the exception tests for the latest version of xarray by peanutfun · Pull Request #827 · CLIMADA-project/climada_python
Navigation Menu
{{ message }}
CLIMADA-project / climada_python Public
- Notifications You must be signed in to change notification settings
- Fork 151
Merged
Fix the exception tests for the latest version of xarray#827
emanuel-schmid merged 3 commits intodevelopfrom
Fix the exception tests for the latest version of xarray#827
emanuel-schmid merged 3 commits intodevelopfrom
Conversation
Copy link
Member
Changes proposed in this PR:
- Update the tests because the latest version of xarray (?) changed the error messages slightly
PR Author Checklist
- Read the Contribution Guide
- Correct target branch selected (if unsure, select
develop) - Descriptive pull request title added
- Source branch up-to-date with target branch
- Documentation updated
- Tests updated
- Tests passing
- No new linter issues
- Changelog updated
PR Reviewer Checklist
- Read the Contribution Guide
- CLIMADA Reviewer Checklist passed
- Tests passing
- No new linter issues
Copy link
Member Author
@emanuel-schmid We should update the environment on Jenkins to make sure that the nightly tests also pass. After merging this, the tests will fail for older versions of xarray.
Edit: Not needed anymore. Code should now work with both versions
peanutfun
requested review from
chahank and
emanuel-schmid
peanutfun added 2 commits
December 12, 2023 16:24Copy link
Member Author
peanutfun
commented
Dec 12, 2023
peanutfun commented
Dec 12, 2023@emanuel-schmid The tests should now work for both the new and the older versions 🙌
Copy link
Member
chahank
commented
Dec 13, 2023
chahank commented
Dec 13, 2023I would then merge or do you want to have another look @peanutfun @emanuel-schmid ?
emanuel-schmid
merged commit
e81249f
into
develop
emanuel-schmid
deleted the
bigfix/xarray-exceptions-tests
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment