Update all workflows to `runs-on: ubuntu-24.04` and Consolidate Capybara Config by aaronskiba · Pull Request #3487

Update all workflows to `runs-on: ubuntu-24.04` and Consolidate Capybara Config by aaronskiba · Pull Request #3487 · DMPRoadmap/roadmap

added 4 commits

March 17, 2025 11:59

- This change modifies the regex to capture the full versions for Ruby and Bundler.

- `imagemagick` is not pre-installed with `ubuntu-24.04`. However, it is required to resolve the following test failures:

```
Failures:

  1) OrgsController PUT /org/admin/:id/admin_update succeeds for feedback changes
     Failure/Error: return if logo.nil? || logo.height == 100

     Dragonfly::Shell::CommandFailed:
       Command failed: identify -ping -format \%m\ \%w\ \%h /tmp/RackMultipart20250324-4505-2x6nam.png, exit status: 127, error: sh: 1: identify: not found
     # ./app/models/org.rb:357:in `resize_image'
     # ./app/controllers/orgs_controller.rb:81:in `admin_update'
     # ./spec/controllers/orgs_controller_spec.rb:60:in `block (3 levels) in <main>'

  2) OrgsController PUT /org/admin/:id/admin_update updates the shibboleth entityID if super_admin and enabled
     Failure/Error: return if logo.nil? || logo.height == 100

     Dragonfly::Shell::CommandFailed:
       Command failed: identify -ping -format \%m\ \%w\ \%h /tmp/RackMultipart20250324-4505-gp3t74.png, exit status: 127, error: sh: 1: identify: not found
     # ./app/models/org.rb:357:in `resize_image'
     # ./app/controllers/orgs_controller.rb:81:in `admin_update'
     # ./spec/controllers/orgs_controller_spec.rb:73:in `block (3 levels) in <main>'

  3) OrgsController PUT /org/admin/:id/admin_update succeeds
     Failure/Error: return if logo.nil? || logo.height == 100

     Dragonfly::Shell::CommandFailed:
       Command failed: identify -ping -format \%m\ \%w\ \%h /tmp/RackMultipart20250324-4505-42hnxo.png, exit status: 127, error: sh: 1: identify: not found
     # ./app/models/org.rb:357:in `resize_image'
     # ./app/controllers/orgs_controller.rb:81:in `admin_update'
     # ./spec/controllers/orgs_controller_spec.rb:43:in `block (3 levels) in <main>'
```

- Moved the `spec/rails_helper.rb` Capybara config to `spec/support/capybara.rb`
  - Rather than pasting the `Capybara.register_driver :headless_chrome` code, the extra `options.add_argument` code was added to `Capybara.register_driver :selenium_chrome_headless_custom`.

- Renamed `:selenium_chrome_headless_add_window_size` to `:selenium_chrome_headless_custom`

aaronskiba changed the title ~~Update all workflows to runs-on: ubuntu-22.04~~ Update all workflows to runs-on: ubuntu-24.04

Mar 24, 2025

aaronskiba changed the title ~~Update all workflows to runs-on: ubuntu-24.04~~ Update all workflows to runs-on: ubuntu-24.04 and Consolidate Capybara Config

Mar 24, 2025