Home Original page

Lower PostgreSQL GitHub Action Chrome Version to Address Breaking Changes Between Latest Chrome Version (134) and `/features` Tests by aaronskiba · Pull Request #3491 · DMPRoadmap/roadmap

Conversation

@aaronskiba

Fixes # (Only a temporary fix for #3485)

Changes proposed in this PR:

  • Replace image-bundled Chrome version with Chrome version 128
    • This change addresses the breaking changes encountered between Chrome version 134 and our /features tests
    • NOTE: This change should be reverted once are /features tests are working with the latest Chrome version
  • Refactored spec/features/modal_search_spec.rb to allow both tests within the file to share the same modal logic 
- This change provides a temporary workaround for the following GitHub Issue: #3485
- This commit should be reverted once our tests are able to run successfully with the latest version of Chrome.

@aaronskiba aaronskiba changed the title TEMP: Lower Chrome Version for Postgres GH Action Lower PostgreSQL GitHub Action Chrome Version to Address Breaking Changes Between Latest Chrome Version (134) and /features Tests

Mar 20, 2025 
This change refactors `spec/features/modal_search_spec.rb` by adding a method which contains the modal logic shared between both of the tests within the file.

johnpinto1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The temporary Chrome downgrade sorts the failing test issues on Github. The refactoring suggested by Rubocop has been done.

@aaronskiba aaronskiba deleted the aaron/issues/downgrade-chrome branch

March 24, 2025 15:01

2 participants

@aaronskiba @johnpinto1