Validate CSV Separator by momo3404 · Pull Request #3569 · DMPRoadmap/roadmap

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@momo3404

Copy link Copy Markdown

Collaborator

@momo3404 momo3404 commented

Oct 6, 2025

Fixes CSV separators not being validated.

Changes proposed in this PR:

  • Refactor the sep_param method in usage_controller to validate that the provided CSV field separator is a safe, predefined character.
  • This mitigates a CSV injection vulnerability where a crafted request such as
    /usage_yearly_users?sep=%2c%3dcmd|' /C+powershell'!A0++pbiqh
    could embed a malicious formula into the downloaded CSV. When opened in spreadsheet software (like Excel), it could trigger command execution under certain conditions.

@aaronskiba aaronskiba merged commit ba95292 into next-release/v5.0.2

Oct 6, 2025

5 checks passed

@aaronskiba aaronskiba deleted the momo/add-csv-separator branch

October 6, 2025 19:00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aaronskiba aaronskiba aaronskiba approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@momo3404 @aaronskiba