[feat-#1204][e2e] Add Oracle Logminer E2E Test. by chaozwn · Pull Request #1205 · DTStack/chunjun

@chaozwn

Purpose of this pull request

Which issue you fix

Fixes # (issue).

Checklist:

  • I have executed the 'mvn spotless:apply' command to format my code.
  • I have a meaningful commit message (including the issue id, the template of commit message is '[label-type-#issue-id][fixed-module] a meaningful commit message.')
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have checked my code and corrected any misspellings.
  • My commit is only one. (If there are multiple commits, you can use 'git squash' to compress multiple commits into one.)

@chaozwn

@FlechazoW FlechazoW linked an issue

Aug 31, 2022

that may be closed by this pull request

3 tasks

FlechazoW

public LaunchCommandBuilder withAddJar(List<String> path) {
commands.add("-addjar");
commands.add(GsonUtil.GSON.toJson(path));
commands.add(new GsonBuilder().create().toJson(path));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why use new Gson rather than GsonUtil.GSON?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this time, because GsonUtil uses prettyjson by default, when using the shell to submit, we cannot appear \r\n json data.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The json we use must be one line of data.

FlechazoW

public LaunchCommandBuilder withFlinkCustomConf(Map<String, Object> properties) {
commands.add("-confProp");
commands.add(GsonUtil.GSON.toJson(properties));
commands.add(new GsonBuilder().create().toJson(properties));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why use new Gson rather than GsonUtil.GSON?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ablove.

@chaozwn