fix bug that lack param of batchSize for Doris Sink config by baisui1981 · Pull Request #1213 · DTStack/chunjun
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 1.7k
Merged
FlechazoW merged 2 commits intoDTStack:masterfrom
Sep 3, 2022Merged
fix bug that lack param of batchSize for Doris Sink config #1213
FlechazoW merged 2 commits intoDTStack:masterfrom
fix bug that lack param of batchSize for Doris Sink config #1213
FlechazoW merged 2 commits intoDTStack:masterfrom
Conversation
Copy link
Contributor
baisui1981
commented
Sep 3, 2022
baisui1981
commented
Purpose of this pull request
Which issue you fix
Fixes # (issue 1171).
Checklist:
- I have executed the 'mvn spotless:apply' command to format my code.
- I have a meaningful commit message (including the issue id, the template of commit message is '[label-type-#issue-id][fixed-module] a meaningful commit message.')
- I have performed a self-review of my own code.
- I have commented my code, particularly in hard-to-understand areas.
- I have made corresponding changes to the documentation.
- I have added tests that prove my fix is effective or that my feature works.
- New and existing unit tests pass locally with my changes.
- I have checked my code and corrected any misspellings.
- My commit is only one. (If there are multiple commits, you can use 'git squash' to compress multiple commits into one.)
baisui1981 and others added 2 commits
September 3, 2022 15:03fix the bug issue for https://github.com/DTStack/chunjun/issues/1171,By the way, has add an other lacked param ‘FlushIntervalMills’ for DorisConf Signed-off-by: 百岁 <mozhenghua19811109@126.com>
3 tasks
FlechazoW
merged commit
893fb60
into
DTStack:master
Copy link
Contributor
Paddy0523
commented
Sep 5, 2022
Paddy0523 commented
Sep 5, 2022LGTM @FlechazoW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment