fix bug that lack param of batchSize for Doris Sink config by baisui1981 · Pull Request #1213 · DTStack/chunjun

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@baisui1981

Copy link

Contributor

Purpose of this pull request

Which issue you fix

Fixes # (issue 1171).

Checklist:

  • I have executed the 'mvn spotless:apply' command to format my code.
  • I have a meaningful commit message (including the issue id, the template of commit message is '[label-type-#issue-id][fixed-module] a meaningful commit message.')
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have checked my code and corrected any misspellings.
  • My commit is only one. (If there are multiple commits, you can use 'git squash' to compress multiple commits into one.)

baisui1981 and others added 2 commits

September 3, 2022 15:03
fix the bug issue for https://github.com/DTStack/chunjun/issues/1171,By the way, has add an other lacked param ‘FlushIntervalMills’ for DorisConf

Signed-off-by: 百岁 <mozhenghua19811109@126.com>

@FlechazoW FlechazoW added the bug

Something isn't working

label

Sep 3, 2022

@FlechazoW FlechazoW linked an issue

Sep 3, 2022

that may be closed by this pull request

3 tasks

@FlechazoW FlechazoW merged commit 893fb60 into DTStack:master

Sep 3, 2022

@Paddy0523

Copy link

Contributor

LGTM @FlechazoW

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug

Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] [Doris Sink] param of batchSize set to Doris Sink config is useless

3 participants

@baisui1981 @Paddy0523 @FlechazoW