[test-#1238] Add unit test for core by kyo-tom · Pull Request #1239 · DTStack/chunjun

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@kyo-tom

Copy link

Contributor

@kyo-tom kyo-tom commented

Sep 9, 2022

Purpose of this pull request

Add junit5、testcontainers dep to flinkx parent pom and add unit test for core module.

Which issue you fix

Fixes # (issue).
#1238

Checklist:

  • I have executed the 'mvn spotless:apply' command to format my code.
  • I have a meaningful commit message (including the issue id, the template of commit message is '[label-type-#issue-id][fixed-module] a meaningful commit message.')
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have checked my code and corrected any misspellings.
  • My commit is only one. (If there are multiple commits, you can use 'git squash' to compress multiple commits into one.)

@kyo-tom kyo-tom requested a review from FlechazoW

September 9, 2022 03:18

@kyo-tom kyo-tom force-pushed the unit-test-core branch 3 times, most recently from e568dbe to 743de02 Compare

September 9, 2022 03:28

@FlechazoW

Copy link

Member

New file add license please.

@FlechazoW FlechazoW added the good first issue

Good for newcomers

label

Sep 9, 2022

@FlechazoW FlechazoW linked an issue

Sep 9, 2022

that may be closed by this pull request

3 tasks

@FlechazoW FlechazoW merged commit 78600f2 into DTStack:master

Sep 9, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FlechazoW FlechazoW Awaiting requested review from FlechazoW

Assignees

No one assigned

Labels

good first issue

Good for newcomers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Test][Core] Unit test for chunjun core

2 participants

@kyo-tom @FlechazoW