[test-#1238] Add unit test for core by kyo-tom · Pull Request #1239 · DTStack/chunjun
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 1.7k
Merged
FlechazoW merged 1 commit intoDTStack:masterfrom
Sep 9, 2022Merged
[test-#1238] Add unit test for core#1239
FlechazoW merged 1 commit intoDTStack:masterfrom
[test-#1238] Add unit test for core#1239
FlechazoW merged 1 commit intoDTStack:masterfrom
Conversation
Copy link
Contributor
kyo-tom
commented
Sep 9, 2022
kyo-tom
commented
Purpose of this pull request
Add junit5、testcontainers dep to flinkx parent pom and add unit test for core module.
Which issue you fix
Fixes # (issue).
#1238
Checklist:
- I have executed the 'mvn spotless:apply' command to format my code.
- I have a meaningful commit message (including the issue id, the template of commit message is '[label-type-#issue-id][fixed-module] a meaningful commit message.')
- I have performed a self-review of my own code.
- I have commented my code, particularly in hard-to-understand areas.
- I have made corresponding changes to the documentation.
- I have added tests that prove my fix is effective or that my feature works.
- New and existing unit tests pass locally with my changes.
- I have checked my code and corrected any misspellings.
- My commit is only one. (If there are multiple commits, you can use 'git squash' to compress multiple commits into one.)
kyo-tom
requested a review
from FlechazoW
kyo-tom
force-pushed
the
unit-test-core
branch
3 times, most recently
from
e568dbe to
743de02
Compare
Copy link
Member
FlechazoW
commented
Sep 9, 2022
FlechazoW commented
Sep 9, 2022New file add license please.
3 tasks
kyo-tom
force-pushed
the
unit-test-core
branch
from
743de02 to
6593f6a
Compare
FlechazoW
merged commit
78600f2
into
DTStack:master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment