[hotfix-#899][conf] fix config check error by huyuanfeng2018 · Pull Request #902 · DTStack/chunjun
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 1.7k
Merged
FlechazoW merged 1 commit intoDTStack:masterfrom
Jun 2, 2022Merged
[hotfix-#899][conf] fix config check error#902
FlechazoW merged 1 commit intoDTStack:masterfrom
[hotfix-#899][conf] fix config check error#902
FlechazoW merged 1 commit intoDTStack:masterfrom
Conversation
Copy link
Contributor
Paddy0523
commented
Jun 1, 2022
Paddy0523 commented
Jun 1, 2022@FlechazoW
I think this can be merged
Copy link
Member
FlechazoW
commented
Jun 1, 2022
FlechazoW commented
Jun 1, 2022Ok. I will merge it, but before that, can you edit the commit message according to the template [hotfix-#issueID][fix-module] fix-commit. @huyuanfeng2018
ll076110
self-requested a review
Copy link
Contributor Author
huyuanfeng2018
commented
Jun 1, 2022
huyuanfeng2018 commented
Jun 1, 2022Ok. I will merge it, but before that, can you edit the commit message according to the template [hotfix-#issueID][fix-module] fix-commit. @huyuanfeng2018
ok I will edit
huyuanfeng2018
changed the title
Fix config check error
[hotfix-#899][conf] fix config check error
Copy link
Member
FlechazoW
commented
Jun 2, 2022
FlechazoW commented
Jun 2, 2022Hey bro, you should change the commit message of this pr, not the title.
Copy link
Member
FlechazoW
commented
Jun 2, 2022
FlechazoW commented
Jun 2, 2022
huyuanfeng2018
force-pushed
the
fix-check-error
branch
from
ba8aa31 to
3d8b437
Compare
huyuanfeng2018
force-pushed
the
fix-check-error
branch
from
3d8b437 to
769ac2d
Compare
Copy link
Contributor Author
huyuanfeng2018
commented
Jun 2, 2022
huyuanfeng2018 commented
Jun 2, 2022i got it
FlechazoW
merged commit
3fabf87
into
DTStack:master
huyuanfeng2018
deleted the
fix-check-error
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment