fix: remove extra task by astuyve · Pull Request #854 · DataDog/datadog-lambda-extension
Navigation Menu
{{ message }}
DataDog / datadog-lambda-extension Public
- Notifications You must be signed in to change notification settings
- Fork 17
Merged
Conversation
Copy link
Contributor
astuyve
commented
Sep 19, 2025
astuyve
commented
Both the otlp agent and telemetry client themselves spawn tasks, we probably don't need another task to do the spawning.
astuyve
requested a review
from a team
as a code owner
Copy link
Contributor
duncanista
commented
Sep 19, 2025
duncanista commented
Sep 19, 2025Wondering if it would make more sense to remove the task being created inside of them, that way the API is more friendly? anyhow, not a blocker, approving
duncanista approved these changes Sep 19, 2025
Copy link
Contributor Author
astuyve
commented
Sep 19, 2025
astuyve commented
Sep 19, 2025Yeah the .spin() methods kinda do that. I'm torn/not sure
astuyve
deleted the
aj/remove-double-task
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants