fix: Drop guard so we don't hold the lock when we may get traces at a… by astuyve · Pull Request #873 · DataDog/datadog-lambda-extension

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@astuyve

Copy link

Contributor

@astuyve astuyve commented

Sep 26, 2025

…ny time

Fixes an issue where in certain runtimes (go/java) which flush traces asynchronously, we may hold this lock too long. This causes tokio tasks at the API/trace aggr to pile up and cause a deadlock

@astuyve astuyve requested a review from a team as a code owner

September 26, 2025 14:09
Copy link

Contributor

@duncanista duncanista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡

@astuyve astuyve merged commit 210ca32 into main

Sep 26, 2025

46 checks passed

@astuyve astuyve deleted the aj/fix-deadlock-trace-flush branch

September 26, 2025 14:30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@duncanista duncanista duncanista approved these changes

@litianningdatadog litianningdatadog litianningdatadog approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@astuyve @duncanista @litianningdatadog