feat: Aggregate tasks into chunks sooner, then drop the lock by astuyve · Pull Request #889 · DataDog/datadog-lambda-extension

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@astuyve

Copy link

Contributor

@astuyve astuyve commented

Oct 6, 2025

Spawning off the send tasks is usually very fast but occasionally tokio will task switch us and we'll end up waiting for coalesce_traces which is a longer blocking operation so we try to aggregate all the batches first then drop the lock as fast as we can. Note that we moved the lock hold into a closure so we removed the explicit drop here

@astuyve astuyve requested a review from a team as a code owner

October 6, 2025 19:35

@astuyve astuyve merged commit f12e410 into main

Oct 8, 2025

38 checks passed

@astuyve astuyve deleted the aj/drop-lock-sooner branch

October 8, 2025 17:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@duncanista duncanista duncanista approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@astuyve @duncanista