[SVLS-7885] update tag splitting to allow for ',' and ' ' by jchrostek-dd · Pull Request #916 · DataDog/datadog-lambda-extension
Navigation Menu
{{ message }}
DataDog / datadog-lambda-extension Public
- Notifications You must be signed in to change notification settings
- Fork 17
Merged
[SVLS-7885] update tag splitting to allow for ',' and ' '#916
jchrostek-dd merged 2 commits intomainfrom
[SVLS-7885] update tag splitting to allow for ',' and ' '#916
jchrostek-dd merged 2 commits intomainfrom
Conversation
Copy link
Contributor
Overview
We currently split theDD_TAGS only by ,. Customer is asking if we can also split by spaces since that is common for container images and lambda lets you deploy images. (https://docs.datadoghq.com/getting_started/tagging/assigning_tags/?tab=noncontainerizedenvironments)
jchrostek-dd
requested a review
from a team
as a code owner
astuyve approved these changes Nov 6, 2025
litianningdatadog requested changes Nov 6, 2025
bottlecap/src/config/mod.rs
Show resolved
Hide resolved
bottlecap/src/config/mod.rs Show resolved Hide resolved
litianningdatadog requested changes Nov 6, 2025
| } | ||
| let parts = tag.split(':').collect::<Vec<&str>>(); | ||
| if parts.len() == 2 { | ||
| map.insert(parts[0].to_string(), parts[1].to_string()); |
Copy link
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact I meant to change below to skip empty key or value
if parts.len() == 2 && !parts[0].is_empty() && !parts[1].is_empty()
Copy link
Contributor Author
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added.
litianningdatadog approved these changes Nov 7, 2025
jchrostek-dd
deleted the
john/update-tag-splitting
branch
duncanpharvey pushed a commit that referenced this pull request
Mar 10, 2026## Overview We currently split the`DD_TAGS` only by `,`. Customer is asking if we can also split by spaces since that is common for container images and lambda lets you deploy images. (https://docs.datadoghq.com/getting_started/tagging/assigning_tags/?tab=noncontainerizedenvironments)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants