parse_util: include cstdint to fix compilation under GCC 13 by malt3 · Pull Request #114 · DataDog/dd-trace-cpp

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Merged

dmehala merged 1 commit intoDataDog:mainfrom

malt3:fix/parse_util_cstdint

Apr 23, 2024

Merged

parse_util: include cstdint to fix compilation under GCC 13#114

dmehala merged 1 commit intoDataDog:mainfrom

malt3:fix/parse_util_cstdint

Conversation

@malt3

Copy link Copy Markdown

Contributor

@malt3 malt3 commented

Apr 22, 2024

Since GCC 13, std::uint64_t and friends require an explicit include of <cstdint>.
See also https://gcc.gnu.org/gcc-13/porting_to.html#header-dep-changes

dmehala reacted with rocket emoji
Since GCC 13, std::uint64_t and friends require an explicit include of
`<cstdint>`.
See also https://gcc.gnu.org/gcc-13/porting_to.html#header-dep-changes

Co-authored-by: Paul Meyer <49727155+katexochen@users.noreply.github.com>
Copy link Copy Markdown

Collaborator

@dmehala dmehala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmehala dmehala merged commit 3a8e1e9 into DataDog:main

Apr 23, 2024

@malt3 malt3 deleted the fix/parse_util_cstdint branch

April 25, 2024 05:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmehala dmehala dmehala approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@malt3 @dmehala