fix: trim inspected headers by dmehala · Pull Request #137 · DataDog/dd-trace-cpp
Conversation
Description
Fixed a regression introduced in issue #42 that prevented HTTP headers with leading spaces from being parsed. This issue could result in the failure to extract trace context and the creation of a new trace, even though the trace could have been extracted and continued in versions prior to v0.1.11.
Fixed a regression introduced in #42 preventing HTTP headers with leading spaces to be parsed.
Codecov Report
All modified and coverable lines are covered by tests ✅
Please upload report for BASE (
main@26e666f). Learn more about missing BASE report.
Additional details and impacted files
@@ Coverage Diff @@ ## main #137 +/- ## ======================================= Coverage ? 94.48% ======================================= Files ? 71 Lines ? 3720 Branches ? 0 ======================================= Hits ? 3515 Misses ? 205 Partials ? 0
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dmehala
deleted the
dmehala/trim-datadog-headers
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters