feat: add telemetry logs by dmehala · Pull Request #185

feat: add telemetry logs by dmehala · Pull Request #185 · DataDog/dd-trace-cpp

Conversation

Description

Add support telemetry logs

Note to reviewers

This PR only adds the API for collecting and reporting logs. As of now, the library is not yet reporting logs because I am planning to refactor the whole telemetry module and error handling.

Codecov Report

❌ Patch coverage is 26.66667% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.16%. Comparing base (f3ebccc) to head (736590f).
⚠️ Report is 93 commits behind head on main.

Files with missing lines	Patch %	Lines
src/datadog/tracer_telemetry.cpp	8.33%	22 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #185      +/-   ##
==========================================
- Coverage   93.60%   93.16%   -0.45%     
==========================================
  Files          73       73              
  Lines        4256     4286      +30     
==========================================
+ Hits         3984     3993       +9     
- Misses        272      293      +21

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. Don't we want to add a test for logs payload as well ? Maybe you want to do it after the refactoring. I could get that.

		class Telemetry {
		/// The telemetry class is responsible for handling internal telemetry data to
		/// track Datadog product usage. It _can_ collect and report logs and metrics.
		///

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we have private headers ? If yes, is there a reason to put the file in the public headers and say do not use ?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imagine I am implementing appsec, how Datadog user/integrator outside of the tracer could use it if it's private?

Benchmarks

Benchmark execution time: 2025-02-15 13:41:10

Comparing candidate commit 736590f in PR branch dmehala/telemetry-logs with baseline commit f3ebccc in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

dmehala deleted the dmehala/telemetry-logs branch

February 16, 2025 18:17