Feature: Sampling delegation by dmehala · Pull Request #59

Feature: Sampling delegation by dmehala · Pull Request #59 · DataDog/dd-trace-cpp

added 3 commits

September 26, 2023 13:34

- Protect `struct SamplingDelegation` with a mutex.
- Check the result of `finalize_config(config3)` in `test_tracer.cpp`.

Since there were quite a few conflicts, there's a fair bit of
restructuring here as well.

dgoffredo deleted the dmehala/sampling-delegation branch

January 12, 2024 13:37

cataphract pushed a commit to cataphract/dd-trace-cpp that referenced this pull request

Mar 28, 2024

* feat: Set integration informations

* run `make format`

---------

Co-authored-by: David Goffredo <david.goffredo@datadoghq.com>

dmehala added a commit that referenced this pull request

Jun 19, 2024

This fixes a regression introduced by Sampling Delegation (#59).
When the sampling delegation header is present during the trace context
extraction, the sampling priority is discarded even if the feature is
disabled.

This change of behaviour can potentially result in
an increase of ingested spans. Additionnally, the tracer should behave
as before the introduction of this feature when it is not enabled.

Changes:
  - Sampling priority is not longer discard when
  `x-datadog-delegate-trace-sampling` is present.
  - Update sampling delegation tests.

dmehala added a commit that referenced this pull request

Jun 19, 2024

This fixes a regression introduced by Sampling Delegation (#59).
When the sampling delegation header is present during the trace context
extraction, the sampling priority is discarded even if the feature is
disabled.

This change of behaviour can potentially result in
an increase of ingested spans. Additionnally, the tracer should behave
as before the introduction of this feature when it is not enabled.

Changes:
  - Sampling priority is not longer discard when
  `x-datadog-delegate-trace-sampling` is present.
  - Update sampling delegation tests.

dmehala added a commit that referenced this pull request

Jun 19, 2024

This fixes a regression introduced by Sampling Delegation (#59).
When the sampling delegation header is present during the trace context
extraction, the sampling priority is discarded even if the feature is
disabled.

This change of behaviour can potentially result in
an increase of ingested spans. Additionnally, the tracer should behave
as before the introduction of this feature when it is not enabled.

Changes:
  - Sampling priority is not longer discard when
  `x-datadog-delegate-trace-sampling` is present.
  - Update sampling delegation tests.

dmehala added a commit that referenced this pull request

Jun 20, 2024

This fixes a regression introduced by Sampling Delegation (#59).
When the sampling delegation header is present during the trace context
extraction, the sampling priority is discarded even if the feature is
disabled.

This change of behaviour can potentially result in
an increase of ingested spans. Additionally, the tracer should behave
as before the introduction of this feature when it is not enabled.

Changes:
  - Sampling priority is not longer discard when`x-datadog-delegate-trace-sampling` is present.
  - Update sampling delegation tests.