Set default timeout on curl handles by dmehala · Pull Request #66

Set default timeout on curl handles by dmehala · Pull Request #66 · DataDog/dd-trace-cpp

- curl default implementation set a 2s default timeout
- drain waits indefinitely until the predicate is valid

- Need to talk about `clock`

- `easy_setopt_timeout`  ->  `easy_setopt_timeout_ms`
- remove `HTTPClient::Deadline` alias
- pass `Clock` into `CurlImpl`
    - `finalize_config(const TracerConfig&, const Clock&)`
    - `FinalizedTracerConfig::clock`
    - `finalize_config(const DatadogAgentConfig&, const Clock&)`
    - `default_http_client(const shared_ptr<Logger>&, const Clock&)`
    - `FinalizedDatadogAgentConfig::clock`
    - `DatadogAgent::DatadogAgent`
- more specific `Error::CURL_DEADLINE_EXCEEDED_BEFORE_REQUEST_START`,
  and a little context in the error message
- `dummy_timeout`  ->  `dummy_deadline`
- `TEST_CASE` for `Error::CURL_DEADLINE_EXCEEDED_BEFORE_REQUEST_START`

dmehala deleted the dmehala/fix-curl-issue branch

November 15, 2023 13:05

cataphract pushed a commit to cataphract/dd-trace-cpp that referenced this pull request

Mar 28, 2024

- Remove dependency on `nginx-version-info` to build the module locally. Only `build-in-docker` need it now.
- Rework CMake target.
- Update README.
- Remove support for old NGINX versions.