Fix PySide6 AttributeError and uninitialized variable by jeylau · Pull Request #2622 · DeepLabCut/DeepLabCut
Navigation Menu
{{ message }}
DeepLabCut / DeepLabCut Public
- Notifications You must be signed in to change notification settings
- Fork 1.8k
Merged
Fix PySide6 AttributeError and uninitialized variable#2622
MMathisLab merged 2 commits intopytorch_dlcfrom
Fix PySide6 AttributeError and uninitialized variable#2622
MMathisLab merged 2 commits intopytorch_dlcfrom
Conversation
jeylau added 2 commits
June 18, 2024 10:09
jeylau
requested review from
MMathisLab and
n-poulsen
MMathisLab approved these changes Jun 18, 2024
Copy link
Member
MMathisLab
left a comment
MMathisLab
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, but why would this not be caught in the unit testing? Maybe check the tests as well for "future proofing🤓"
MMathisLab
merged commit
853b7fd
into
pytorch_dlc
jeylau
mentioned this pull request
2 tasks
MMathisLab
deleted the
jeylau/gui-fix
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment