Fix: correct the early return error when save_epochs=1 and optimize the clean up way by xiu-cs · Pull Request #2793 · DeepLabCut/DeepLabCut
Navigation Menu
{{ message }}
DeepLabCut / DeepLabCut Public
- Notifications You must be signed in to change notification settings
- Fork 1.8k
Merged
n-poulsen merged 4 commits intoDeepLabCut:pytorch_dlcfrom
Nov 25, 2024Merged
Conversation
Copy link
Contributor
- Fixed an issue causing an incorrect early return when save_epochs=1.
- clean up old snapshots if the number of existing snapshots exceeds the maximum allowed (executed at the end of the process).
Special thanks to @n-poulsen for your invaluable guidance! 🙏
…e redunant snapshots at the end
n-poulsen
self-requested a review
n-poulsen
added
the
DLC3.0🔥
label
n-poulsen suggested changes Nov 22, 2024
Copy link
Contributor
n-poulsen
left a comment
n-poulsen
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome thank you @xiu-cs! Just requested a few minor changes and some linting :)
deeplabcut/pose_estimation_pytorch/runners/snapshots.py
Outdated
Show resolved
Hide resolved
deeplabcut/pose_estimation_pytorch/runners/snapshots.py Outdated Show resolved Hide resolved
deeplabcut/pose_estimation_pytorch/runners/snapshots.py
Outdated
Show resolved
Hide resolved
deeplabcut/pose_estimation_pytorch/runners/snapshots.py Outdated Show resolved Hide resolved
xiu-cs and others added 2 commits
November 22, 2024 13:47Co-authored-by: n-poulsen <45132115+n-poulsen@users.noreply.github.com>
xiu-cs
requested a review
from n-poulsen
n-poulsen
mentioned this pull request
xiu-cs
force-pushed
the
ti/snapshots
branch
from
b91a3f8 to
f670407
Compare
n-poulsen approved these changes Nov 25, 2024
Copy link
Contributor
n-poulsen
left a comment
n-poulsen
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks @xiu-cs!
n-poulsen
merged commit
73ddd56
into
DeepLabCut:pytorch_dlc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment