Add missing positional arguments to SuperAnimal Colab by maximpavliv · Pull Request #2819 · DeepLabCut/DeepLabCut
Navigation Menu
{{ message }}
DeepLabCut / DeepLabCut Public
- Notifications You must be signed in to change notification settings
- Fork 1.8k
Merged
Add missing positional arguments to SuperAnimal Colab#2819
n-poulsen merged 1 commit intopytorch_dlcfrom
Add missing positional arguments to SuperAnimal Colab#2819
n-poulsen merged 1 commit intopytorch_dlcfrom
Conversation
Copy link
Contributor
maximpavliv
commented
Dec 19, 2024
maximpavliv
commented
The Superanimal colab was missing positional arguments, so I updated it
maximpavliv
requested a review
from n-poulsen
maximpavliv
force-pushed
the
maxim/fix_superanimal_colab
branch
from
ff5f950 to
9bdc44f
Compare
Copy link
Contributor Author
maximpavliv
commented
Dec 20, 2024
maximpavliv commented
Dec 20, 2024@n-poulsen model_name is a positional argument of video_inference_superanimal() and was missing in this Colab.
I am not sure if I added the best default one, can you double-check and confirm please?
n-poulsen approved these changes Dec 20, 2024
Copy link
Contributor
n-poulsen
left a comment
n-poulsen
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @maximpavliv! Looks good to me!
n-poulsen
added
DLC3.0🔥
COLAB
labels
n-poulsen
merged commit
3130038
into
pytorch_dlc
n-poulsen
deleted the
maxim/fix_superanimal_colab
branch
maximpavliv added a commit that referenced this pull request
Dec 20, 2024This reverts commit 3130038.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment