Use f-strings instead of format or old-style % by mulhod · Pull Request #634 · EducationalTestingService/skll
According to the codecov diff, coverage increases very slightly by 0.01%. So, why the codecov check itself is not passing I'm not really sure.
@mulhod can you push another commit?
Or perhaps I'm just reading it wrong? The codecov/patch check failed. But not codecov/project.
Anyway something failed.
Yeah, that's the patch diff that failed – which checks whether any new lines you added are also covered by tests. I am guessing these are because you broke some long strings into smaller ones?
I did break some lines up, but it appears the total didn't change by much. Maybe 2 lines more?
Anyway, it's a little unclear to me how this can be addressed or if it should.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏽 !
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one small suggestion, else it LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters