Deprecate `log` field in configuration files. by desilinguist · Pull Request #705

Deprecate `log` field in configuration files. by desilinguist · Pull Request #705 · EducationalTestingService/skll

Merged

desilinguist merged 3 commits intomainfrom

671-deprecate-log-field

Dec 8, 2021

Merged

Deprecate `log` field in configuration files. #705
desilinguist merged 3 commits intomainfrom
671-deprecate-log-field

Conversation

Copy link

Collaborator

desilinguist commented
Dec 8, 2021

This PR closes #671.

Remove temporary workaround to allow log instead of logs in the config files.
Update relevant test to check for an error instead of a warning.
Update all other tests that still relied on log field.

desilinguist added 3 commits

December 8, 2021 11:45

Remove any checks for the log config field.

bc19dfe

Update the test

7cd0d84

- The test that uses `log` in the config file should now raise a KeyError instead of a warning.

Update all tests to use logs instead of log.

48c48c7

desilinguist requested review from a user, Frost45, damien2012eng and mulhod

December 8, 2021 18:36

Copy link

codecov bot commented
Dec 8, 2021
•

edited

Loading

Codecov Report

Merging #705 (48c48c7) into main (f116e57) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #705      +/-   ##
==========================================
- Coverage   96.89%   96.89%   -0.01%     
==========================================
  Files          63       63              
  Lines        9213     9199      -14     
==========================================
- Hits         8927     8913      -14     
  Misses        286      286

Impacted Files	Coverage Δ
skll/config/__init__.py	`95.13% <ø> (-0.16%)`	⬇️
tests/test_classification.py	`100.00% <ø> (ø)`
tests/test_output.py	`100.00% <ø> (ø)`
tests/test_input.py	`99.80% <100.00%> (-0.01%)`	⬇️
tests/test_regression.py	`99.64% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f116e57...48c48c7. Read the comment docs.